Skip to content

Commit

Permalink
chore(): Update changes from code review
Browse files Browse the repository at this point in the history
Blank lines at end of documents
rewording some docs
Spacing between ansible-lint-ignore rules
Variable names
remove uneccessry info in teams.md
  • Loading branch information
jasonpagetas committed Aug 19, 2024
1 parent eee170f commit fec74f0
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 12 deletions.
9 changes: 6 additions & 3 deletions .ansible-lint-ignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
galaxy.yml galaxy[version-incorrect]
# This playbook will only ever be run against the centurion host

# N/A as the play runs on the ansible controller and should only run once.
playbooks/teams.yaml run-once[task]
# This task only saves the report on the local machine and is deleted after uploading
playbooks/inventory.yaml risky-file-permissions

# N/A as the play runs on the ansible controller using permissions of executing user.
playbooks/inventory.yaml risky-file-permissions

Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ Available playbooks include:

- [Inventory](./inventory.md)
- [Teams](./teams.md)

8 changes: 3 additions & 5 deletions docs/projects/ansible/collection/centurion/playbooks/teams.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Teams
description: Creation and patching of teams and permissions.
description: Creation and patching of Centurion ERP teams and permissions
date: 2024-08-18
template: project.html
about: https://github.com/nofusscomputing/ansible_collection_centurion
Expand All @@ -16,7 +16,7 @@ The following job template will be created:


!!! info
The playbook is able to work with Centurion ERP directly or using the inventory pluggin that is included in this collection.
The playbook is able to work with the inventory plugin that is included in this collection.


## Play workflow
Expand Down Expand Up @@ -58,6 +58,4 @@ centurion_erp:
team_name_notes: &team-name-notes "team_notes"

```

!!! info "Upcoming feature"
With the release of Centurion ERP V1.1 an API request to fetch all permissions that can be applied will be available.

5 changes: 3 additions & 2 deletions playbooks/inventory.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,11 @@
type: boolean
label: Validate SSL Certificate
required:
- itsm_api
- itsm_token
- centurion_api
- centurion_token
injectors: >
env:
CENTURION_API: '{{ centurion_url }}'
CENTURION_TOKEN: '{{ centurion_token }}'
CENTURION_VALIDATE_CERTS: '{{ centurion_validate_certs | default(true) }}'
5 changes: 3 additions & 2 deletions playbooks/teams.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,11 @@
job_type: "run"
# job_tags: complete
labels:
- access
- centurion_erp
- itsm
- itam
- access
- itsm
- permissions
- teams
use_fact_cache: true

0 comments on commit fec74f0

Please sign in to comment.