Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when adding team via API permissions can't be included #159

Closed
jon-nfc opened this issue Jul 27, 2024 · 14 comments
Closed

when adding team via API permissions can't be included #159

jon-nfc opened this issue Jul 27, 2024 · 14 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed Migrated from Gitlab This issue/PR was migrated from GitLab see #213 type::feature type for Issues and Merge Requests. Can also be used in discussion in comments and commits
Milestone

Comments

@jon-nfc
Copy link
Member

jon-nfc commented Jul 27, 2024

In GitLab by @jasonpagetas on Jul 27, 2024, 01:57

Swagger documentation does not provide instruction for adding permissions to a team.

Current examples in /api/organization/{organization_id}/team only show the following:

{
  "team_name": "string"
}

This needs to be updated to include permissions

Additionally it appears that a team id is required (mandatory) to create a team.

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 27, 2024

added 2m of time spent

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 28, 2024

url to add permissions to an existing team is /api/organization/<int:organization_id>/team/<int:group_ptr_id>/permissions and accepts a list of string.

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 28, 2024

added 5m of time spent

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 28, 2024

In GitLab by @jasonpagetas on Jul 28, 2024, 07:42

marked this issue as related to #74

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 28, 2024

@jasonpagetas

Additionally it appears that a team id is required (mandatory) to create a team.

what gives that impression?

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 28, 2024

added 2m of time spent

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 29, 2024

mentioned in commit 0e426f5a641c24f7e8a7e7e97d751df3ceb169ec

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 29, 2024

mentioned in commit a45971d2159f5ba27aa103f63f46d25bf97c83d0

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 29, 2024

mentioned in commit bb9870806a110dec6f23b42952e75f3510e28af0

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 29, 2024

removing from milestone v1.0.0 as the docs have been cleaned up for clarity. this issue will be scheduled to a later milestone.

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 29, 2024

mentioned in commit 9b673f4

@jon-nfc
Copy link
Member Author

jon-nfc commented Jul 29, 2024

mentioned in commit 3a9e4b2

@jon-nfc jon-nfc self-assigned this Aug 8, 2024
@jon-nfc jon-nfc added Migrated from Gitlab This issue/PR was migrated from GitLab see #213 good first issue Good for newcomers help wanted Extra attention is needed and removed module::api labels Aug 8, 2024
@jon-nfc jon-nfc mentioned this issue Aug 8, 2024
12 tasks
@jon-nfc
Copy link
Member Author

jon-nfc commented Aug 8, 2024

@jasonpagetas, this issue was migrated from gitlab to github. During this migration you were not added as the user whom opened this issue. This message will ensure that you receive further updates on this issue as it progresses.

Further information can be found within #213

@jon-nfc jon-nfc added this to the v1.0.0 milestone Aug 12, 2024
@jon-nfc
Copy link
Member Author

jon-nfc commented Aug 12, 2024

closing issue as the crux of the issue is by design and the docs were updated.

@jon-nfc jon-nfc closed this as completed Aug 12, 2024
jon-nfc added a commit that referenced this issue Aug 23, 2024
return HTTP/405 for logged in user ONLY!!

!44 #159
jon-nfc added a commit that referenced this issue Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed Migrated from Gitlab This issue/PR was migrated from GitLab see #213 type::feature type for Issues and Merge Requests. Can also be used in discussion in comments and commits
Projects
Archived in project
Development

No branches or pull requests

1 participant