Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization manager cant view organization #425

Open
6 tasks
Tracked by #421
jon-nfc opened this issue Dec 15, 2024 · 0 comments
Open
6 tasks
Tracked by #421

Organization manager cant view organization #425

jon-nfc opened this issue Dec 15, 2024 · 0 comments
Assignees
Labels
bug::regression Bug reason type::bug Issue Type v1.4.0 Version Affected. v1.5.0 Version Affected. v1.6-beta Version Affected.

Comments

@jon-nfc
Copy link
Member

jon-nfc commented Dec 15, 2024

An organization manager is supposed to be able to virew an organization they are the manager off (uri: /api/v2/access/organization).

Details

as an organization manager the user must have full permissions to an organization. this includes full CRUD for teams of that organization.

Permissions Checking update

The permission checking logic will need to be updated to cater for checking if the user is an org manager if the model is an organization. This could be done within the function has_permissionhas_object_permission or `` (api.views.mixin.mixin.py.OrganizationPermissionAPI) as that allows no mod to default permission checking just for a single permission check.

Links

Requirements

  • user can access organization they are manager of
    reverted see 56112b7. due to failed tests and no time to dive into
  • user can add team to organization they are manager of
  • user can delete team for organization they are manager of
  • user can change team for organization they are manager of

Tasks

  • Unit test
  • Functional test
@jon-nfc jon-nfc added type::bug Issue Type bug::regression Bug reason labels Dec 15, 2024
@jon-nfc jon-nfc added this to the Next Release milestone Dec 15, 2024
@jon-nfc jon-nfc mentioned this issue Dec 15, 2024
10 tasks
@jon-nfc jon-nfc moved this to Planning in Centurion ERP Dec 15, 2024
@jon-nfc jon-nfc self-assigned this Dec 19, 2024
@jon-nfc jon-nfc moved this from Planning to In progress in Centurion ERP Dec 19, 2024
jon-nfc added a commit that referenced this issue Dec 19, 2024
jon-nfc added a commit that referenced this issue Dec 19, 2024
…d the user is a manager allow access to the organization.

ref: #425 #426
jon-nfc added a commit that referenced this issue Dec 19, 2024
…d the user is a manager allow access to the organization.

ref: #425 #426
jon-nfc added a commit that referenced this issue Dec 20, 2024
…d the user is a manager allow access to the organization.

ref: #425 #426
jon-nfc added a commit that referenced this issue Dec 20, 2024
…d the user is a manager allow access to the organization.

ref: #425 #426
jon-nfc added a commit that referenced this issue Dec 20, 2024
…d the user is a manager allow access to the organization.

ref: #425 #426
jon-nfc added a commit that referenced this issue Dec 20, 2024
…and the user is a manager allow access to the organization.

ref: #425 #426
@jon-nfc jon-nfc added v1.4.0 Version Affected. v1.5.0 Version Affected. v1.6-beta Version Affected. labels Dec 21, 2024
@jon-nfc jon-nfc moved this from In progress to Blocked in Centurion ERP Dec 23, 2024
@jon-nfc jon-nfc removed this from the Next Release milestone Dec 23, 2024
@jon-nfc jon-nfc removed the status in Centurion ERP Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::regression Bug reason type::bug Issue Type v1.4.0 Version Affected. v1.5.0 Version Affected. v1.6-beta Version Affected.
Projects
Status: No status
Development

No branches or pull requests

1 participant