Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): history and notes api endpoint #354

Merged
merged 22 commits into from
Oct 19, 2024
Merged

Conversation

jon-nfc
Copy link
Member

@jon-nfc jon-nfc commented Oct 18, 2024

📚 Summary

🔗 Links / References

👷 Tasks


History

  • 🆕 Serializer Created _ path: <module name>/serializers_

    • ✔️ Validations from form included in serializer

    • ✔️ Validations from view included in serializer

    • ✔️ All related fields using its base serializer

    • ☑️ Related Serializers that Don't exist are created

  • 🆕 ViewSet Created _ path: <module name>/viewsets_

    • ✔️ ViewSet added to api/urls.py
    • ✔️ ViewSet added to Module viewsets/index.py
  • 🧪 Tests

    • 🧪 ViewSet Permission tests test_<model name>_permission_viewset.py

    • 🧪 API Fields rendering tests test_<model name>_api_v2.py

    • 🧪 Serializer validation tests - test_<model name>_serializer.py

      each validation conducted is checked to ensure it works

Notes

  • 🆕 Serializer Created _ path: <module name>/serializers_

    • ✔️ Validations from form included in serializer

    • ✔️ Validations from view included in serializer

    • ✔️ All related fields using its base serializer

    • ☑️ Related Serializers that Don't exist are created

  • 🆕 ViewSet Created _ path: <module name>/viewsets_

    • ✔️ ViewSet added to api/urls.py
    • ✔️ ViewSet added to Module viewsets/index.py
  • 🧪 Tests

    • 🧪 ViewSet Permission tests test_<model name>_permission_viewset.py

    • 🧪 API Fields rendering tests test_<model name>_api_v2.py

    • 🧪 Serializer validation tests - test_<model name>_serializer.py

      each validation conducted is checked to ensure it works

Manufacturer

  • 🆕 Serializer Created _ path: <module name>/serializers_

    • ✔️ Validations from form included in serializer

    • ✔️ Validations from view included in serializer

    • ✔️ All related fields using its base serializer

    • ☑️ Related Serializers that Don't exist are created

  • 🆕 ViewSet Created _ path: <module name>/viewsets_

    • ✔️ ViewSet added to api/urls.py
    • ✔️ ViewSet added to Module viewsets/index.py
  • 🧪 Tests

    • 🧪 ViewSet Permission tests test_<model name>_permission_viewset.py

    • 🧪 API Fields rendering tests test_<model name>_api_v2.py

    • 🧪 Serializer validation tests - test_<model name>_serializer.py

      each validation conducted is checked to ensure it works


  • 🧨 Contains breaking-change Any Breaking change(s)?

    Breaking Change must also be notated in the commit that introduces it and in Conventional Commit Format.

    • 📓 Release notes updated
  • 📘 Documentation written

    All features to be documented within the correct section(s). Administration, Development and/or User

  • 🏁 Milestone assigned

  • 🧪 Unit Test(s) Written

    ensure test coverage delta is not less than zero

  • 📄 Roadmap updated

@jon-nfc jon-nfc added this to the v1.3 - UI / API Refactor milestone Oct 18, 2024
@jon-nfc jon-nfc self-assigned this Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

Image Scan Results

Scan Date: 2024-10-19T05:09:19.4996498Z
Image: ghcr.io/nofusscomputing/centurion-erp:3c1abc454e8be4e393096d1e5ffc626bff8d9b73
OS: alpine 3.19.4

Nothing Found

@jon-nfc jon-nfc added the type::feature type for Issues and Merge Requests. Can also be used in discussion in comments and commits label Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

Python Scan Results (requirements.txt)

Scan Date: 2024-10-19T05:08:44.99363172Z
File: requirements.txt

Nothing Found

@jon-nfc jon-nfc changed the title fix(core): history and notes api endpoint feat(core): history and notes api endpoint Oct 18, 2024
@jon-nfc jon-nfc merged commit f90f7a0 into feature-v1-3 Oct 19, 2024
31 of 36 checks passed
@jon-nfc jon-nfc deleted the core-api-v2-endpoint branch October 19, 2024 05:17
jon-nfc added a commit that referenced this pull request Oct 19, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
jon-nfc added a commit that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature type for Issues and Merge Requests. Can also be used in discussion in comments and commits
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant