chore: enforce type on oracle callback function #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
enforce-oracle-callback-type
branch
from
248c92a
to
06b135d
Compare
TomAFrench
added a commit
that referenced
this pull request
May 22, 2023
* master: chore: enforce type on oracle callback function (#15) chore: add jsdoc for `execute_circuit` (#13) chore: add release-please action (#12) chore: add smoketest for build-info (#11) chore(ci): add eslint to CI (#10) feat: Enforce `WitnessMap` type in TS (#9) chore: add type aliases for tests (#7) feat: use JS naming convention for generated functions (#6) chore: remove unnecessary peer dependency
kobyhallx
pushed a commit
to noir-lang/acvm
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Related to #8
Description
Summary of changes
This PR enforces that any oracle callback passed to
execute_circuitmust satisfy the type(name: string, inputs: string[]) => Promise<string[]>Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context