Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add initial testing for running simulator in the browser #3

Merged
merged 9 commits into from
May 19, 2023

Conversation

TomAFrench
Copy link
Member

Related issue(s)

Resolves #

Description

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench changed the title Add initial testing for running simulator in the browser chore(ci): Add initial testing for running simulator in the browser May 19, 2023
@TomAFrench
Copy link
Member Author

I've got this finding the correct file now (I was being dumb and did have a bad import)

This now fails with the error message

test/browser/abi_encode.test.ts:

 ❌ TypeError: Cannot read properties of null (reading 'querySelector') 
      at o.<anonymous> (test/browser/abi_encode.test.ts:10:23)

Chrome: |██████████████████████████████| 1/1 test files | 0 passed, 1 failed

@TomAFrench TomAFrench marked this pull request as ready for review May 19, 2023 12:01
@TomAFrench TomAFrench merged commit 875e952 into master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant