Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Remove Directive opcodes #395

Closed
2 tasks done
TomAFrench opened this issue Jun 21, 2023 · 1 comment
Closed
2 tasks done

Remove Directive opcodes #395

TomAFrench opened this issue Jun 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Jun 21, 2023 •
edited
Loading

Problem

Post noir-lang/noir#1772, the Directive opcode will be unused and replaced with Brillig implementations.

Happy Case

We should remove the Directive opcode to avoid carrying technical debt.

Alternatives Considered

We could maintain this so that other languages building on top of ACIR can get off the ground more easily without full Brillig support.

Additional Context

Tasks
Beta Give feedback
  1. Implement Directive::ToLeRadix in Brillig #473
    enhancement
  2. Implement Directive::PermutationSort in Brillig noir#4751
    enhancement

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@TomAFrench TomAFrench added the enhancement New feature or request label Jun 21, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 21, 2023
@kevaundray kevaundray mentioned this issue Jul 11, 2023
Merged
2 tasks
This was referenced Aug 3, 2023
Closed
Closed
@TomAFrench
Copy link
Member Author

Closing as there's only a single directive left so we can just track that.

@TomAFrench TomAFrench closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomAFrench