Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace directives with brillig opcodes #1772

Open
kevaundray opened this issue Jun 20, 2023 · 3 comments
Open

Replace directives with brillig opcodes #1772

kevaundray opened this issue Jun 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request refactor ssa

Comments

@kevaundray
Copy link
Contributor

Problem

Brillig is a more general version of directives.

We can now start to replace usage of directives with Brillig opcodes in the compiler.

Happy Case

All directives are replaced.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@kevaundray kevaundray added the enhancement New feature or request label Jun 20, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 20, 2023
@kevaundray
Copy link
Contributor Author

This issue which needs the sorting directive will be superceded by this once we implement it as brillig bytecode: #1687

@TomAFrench
Copy link
Member

Not suggesting that we should do this immediately but once we've migrated all directives to brillig, I think it may be useful to push some of this down to a "brillig stdlib" in similarly to how we have acvm_stdlib.

@kevaundray
Copy link
Contributor Author

Not suggesting that we should do this immediately but once we've migrated all directives to brillig, I think it may be useful to push some of this down to a "brillig stdlib" in similarly to how we have acvm_stdlib.

That makes sense -- we have a generated_acir folder in ssa_refactor which has components that could also be migrated to acvm_stdlib -- it essentially just deals with acir construction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants