Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Change CheckMembership opcode to ComputeRoot #66

Closed
kevaundray opened this issue Oct 31, 2022 · 2 comments
Closed

Change CheckMembership opcode to ComputeRoot #66

kevaundray opened this issue Oct 31, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

Problem

Currently, the check membership opcode will compute the merkle root and then add an Eq constraint. The Eq constraint can be computed in Noir.

Solution

Change CheckMembership Opcode to MerkleComputeRoot instead.

Alternatives considered

(Describe any alternative solutions you have considered.)

Additional context

(If applicable.)

@kevaundray kevaundray added the enhancement New feature or request label Oct 31, 2022
@kevaundray
Copy link
Contributor Author

This also requires an change in the acvm repo and all of the backends, so should be done sooner rather than later

@TomAFrench
Copy link
Member

Resolved in #233

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants