This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore(acvm)!: remove prove_with_meta and verify_from_cs from ProofSystemCompiler
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofSystemCompiler`
|
Do we want to hold this PR until 0.7 is closer? I know @guipublic has #138 that wouldn't be breaking and could be released in a 0.6.1 |
|
True, we could hold this to be merged with #137 if we want to avoid another breaking release. |
|
We also have #56 however which should be ready to go in. |
phated
approved these changes
Mar 15, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #139
Description
Summary of changes
I've removed the deprecated methods from
ProofSystemCompilerso that they no longer need to be implemented by backends.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)