This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: Add CommonReferenceString backend trait #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened as a draft to discuss |
phated
commented
Apr 26, 2023
phated
force-pushed
the
phated/ref-string-trait
branch
2 times, most recently
from
4dead53
to
99746c5
Compare
guipublic
suggested changes
May 3, 2023
This was referenced May 3, 2023
Merged
phated
changed the title
phated
force-pushed
the
phated/ref-string-trait
branch
from
3ef2044
to
ce00afa
Compare
1 task
|
This is a significant change to Backends, so we should hold it (even after approvals) until the CRS changes all prepared for the Backend and Nargo. |
TomAFrench
reviewed
May 11, 2023
phated
force-pushed
the
phated/ref-string-trait
branch
from
38ee176
to
5b88ff1
Compare
phated
force-pushed
the
phated/ref-string-trait
branch
from
5b88ff1
to
7da75f7
Compare
vezenovm
approved these changes
May 12, 2023
guipublic
approved these changes
May 15, 2023
|
Will take a look at this in the morning (singapore time) and can merge after. |
TomAFrench
approved these changes
May 16, 2023
|
Looks good, modified one comment. |
TomAFrench
added a commit
that referenced
this pull request
May 16, 2023
* master: (49 commits) feat(acvm)!: Add CommonReferenceString backend trait (#231) fix(acir): Hide variants of WitnessMapError and export it from package (#283) feat!: Introduce WitnessMap data structure to avoid leaking internal structure (#252) feat!: use struct variants for blackbox function calls (#269) chore(acvm)!: Backend trait must implement Debug (#275) chore!: remove `OpcodeResolutionError::UnexpectedOpcode` (#274) chore(acvm)!: rename `hash_to_field128_security` to `hash_to_field_128_security` (#271) feat(acvm)!: update black box solver interfaces to match `pwg:black_box::solve` (#268) chore(acir_field): remove unnecessary `to_vec()` (#267) chore(acvm)!: expose separate solvers for AND and XOR opcodes (#266) feat(acvm)!: Simplification pass for ACIR (#151) changes the name of blake to be blakes2s256 (#261) update hash functions (#260) feat!: Remove `solve` from PWG trait & introduce separate solvers for each blackbox (#257) chore: Release 0.11.0 (#250) feat(acvm): Add generic error for failing to solve an opcode (#251) fix(acir): Fix `Expression` multiplication to correctly handle degree 1 terms (#255) chore(acir): organise opcodes definitions (#254) chore: remove usage of `insert_witness` with `insert_value` (#253) feat: Add Keccak Hash function (#259) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Needed for noir-lang/acvm-backend-barretenberg#160
Description
Summary of changes
This requires a
CommonReferenceStringtrait for ACVM Backends.The reason some functions in other traits were modified to take the
common_reference_stringis because backends can have a circular dependency, such that they need to instantiate themselves before they can get the circuit size for a given circuit and the CRS often needs the circuit size to the data it is using. This means we can't doBackend::new(CRS::new(circuit_size))and resulted the functions that need a CRS taking it as an argument.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)