Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acvm)!: Support stepwise execution of ACIR #399

Merged
merged 16 commits into from
Jul 26, 2023
Merged

feat(acvm)!: Support stepwise execution of ACIR #399

merged 16 commits into from
Jul 26, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Janky implementation of stepwise execution.

Summary*

This PR makes the assumption that each opcode can be executed on the first attempt (excluding foreign calls). We can then implement stepwise execution.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench mentioned this pull request Jun 21, 2023
Merged
2 tasks
TomAFrench
TomAFrench commented Jun 21, 2023
View reviewed changes
acvm/tests/solver.rs Outdated Show resolved Hide resolved
TomAFrench
TomAFrench commented Jun 21, 2023
View reviewed changes
acvm/src/pwg/mod.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench mentioned this pull request Jul 5, 2023
Merged
2 tasks
@TomAFrench TomAFrench changed the base branch from master to acvm-status July 5, 2023 10:12
@TomAFrench TomAFrench changed the base branch from acvm-status to master July 6, 2023 06:44
@TomAFrench TomAFrench mentioned this pull request Jul 11, 2023
Closed
@TomAFrench TomAFrench marked this pull request as ready for review July 17, 2023 09:58
@TomAFrench TomAFrench force-pushed the linear-acvm branch 3 times, most recently from 04599d4 to fb5a924 Compare July 17, 2023 10:41
@TomAFrench TomAFrench linked an issue Jul 17, 2023 that may be closed by this pull request
Remove UnresolvedBrilligCall #416
Closed
@kevaundray
Copy link
Contributor

Is this dependent on #433

@TomAFrench
Copy link
Member Author

Is this dependent on #433

Only to create a new release and have Noir consume it.

@TomAFrench TomAFrench linked an issue Jul 19, 2023 that may be closed by this pull request
Consider renaming foreign_call_wait_info field on UnresolvedBrilligCall #396
Closed
kevaundray
kevaundray reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

acvm/src/compiler/transformers/csat.rs Show resolved Hide resolved
acvm/src/pwg/block.rs Show resolved Hide resolved
acvm/src/pwg/mod.rs Show resolved Hide resolved
acvm/src/pwg/mod.rs Show resolved Hide resolved
acvm/src/pwg/mod.rs Show resolved Hide resolved
acvm/src/pwg/mod.rs Show resolved Hide resolved
acvm/src/pwg/mod.rs Show resolved Hide resolved
@kevaundray
Copy link
Contributor

Hmm seems I left comments and github didn't save them 🤔

kevaundray
kevaundray approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke with Tom on slack, we can deal with these nits in a separate PR

@TomAFrench TomAFrench added this pull request to the merge queue Jul 26, 2023
Merged via the queue into master with commit 6a03950 Jul 26, 2023
@kevaundray kevaundray mentioned this pull request Jul 26, 2023
Merged
@TomAFrench TomAFrench deleted the linear-acvm branch July 26, 2023 08:56
@TomAFrench TomAFrench mentioned this pull request Jul 26, 2023
Merged
2 tasks
@TomAFrench TomAFrench mentioned this pull request Sep 20, 2023
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove UnresolvedBrilligCall Consider renaming foreign_call_wait_info field on UnresolvedBrilligCall
3 participants
@TomAFrench @kevaundray @guipublic