This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix: maintain Opcode
ordering in CSATTransformer
#419
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR stops us from sorting the set of arithmetic opcodes produced by the
CSATTransformer
.Consider the arithmetic opcode
This currently gets transformed into
The 3rd and 4th opcodes have been swapped as the original opcode's linear term gets it sorted before the final intermediate value gate. If we don't sort the gates then we get the result
This is what we expect as the gate which pulls together all of the intermediate values is at the end so can act once these are set.
Additional Context
PR Checklist*
cargo fmt
on default settings.