This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore: add cpp codegen for ACIR [DO NOT MERGE] #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
commented
Jul 12, 2023
acir/acir.cpp
Outdated
Comment on lines
905
to
913
| struct Circuit { | ||
| uint32_t current_witness_index; | ||
| std::vector<Circuit::Opcode> opcodes; | ||
| Circuit::PublicInputs public_parameters; | ||
| Circuit::PublicInputs return_values; | ||
|
|
||
| friend bool operator==(const Circuit&, const Circuit&); | ||
| std::vector<uint8_t> bincodeSerialize() const; | ||
| static Circuit bincodeDeserialize(std::vector<uint8_t>); |
There was a problem hiding this comment.
bberg would then just have to iterate through the opcodes field and construct a ConstraintSystem from this.
|
Now that ACVM has been migrated into noir, we should find a way to put the codegen code in here into the acvm repo in noir for when we want to make serialization changes cc @kobyhallx and @TomAFrench |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #434
Summary*
This PR adds a quick implementation of
serde_reflection. Pushing this up for visibility rather to get it merged as is.serde_reflectionfails if it has two different enums with the same name so I've had to renamebrillig::OpcodetoBrilligOpcode.Additional Context
PR Checklist*
cargo fmton default settings.