Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acvm)!: check for index out-of-bounds on memory operations #468

Merged
merged 3 commits into from
Aug 2, 2023
Merged

feat(acvm)!: check for index out-of-bounds on memory operations #468

merged 3 commits into from
Aug 2, 2023

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves noir issue 1412

Summary*

Add a new index-of-bound error when we access an array with index greater than the array length.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@guipublic guipublic mentioned this pull request Aug 2, 2023
Closed
5 tasks
@TomAFrench TomAFrench changed the title chore!: check for index out-of-bounds on memory operations feat(acvm)!: check for index out-of-bounds on memory operations Aug 2, 2023
TomAFrench
TomAFrench suggested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness can you add a test case showing we get the error if we're doing a bad memory operation?

acvm/src/pwg/memory_op.rs Outdated Show resolved Hide resolved
@guipublic guipublic added this pull request to the merge queue Aug 2, 2023
Merged via the queue into master with commit 740468c Aug 2, 2023
12 checks passed
@kevaundray kevaundray mentioned this pull request Aug 2, 2023
Merged
TomAFrench added a commit that referenced this pull request Aug 3, 2023
@TomAFrench
Merge branch 'master' into combined_history-acvm_js
9f76891 
* master:
  chore: clippy fixes (#469)
  feat(acvm)!: check for index out-of-bounds on memory operations (#468)
@TomAFrench TomAFrench mentioned this pull request Aug 11, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guipublic @TomAFrench