This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Remove duplicated match statement for Directive::Log #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
approved these changes
Feb 8, 2023
TomAFrench
added a commit
to TomAFrench/acvm
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (noir-lang#69) add tests for `from_hex` and `to_hex` (noir-lang#85) improve field formatting (noir-lang#84) chore(ci): Leverage reusable workflows (noir-lang#81) fix clippy (noir-lang#82) 0.4.1 Release remove duplicated match statement for Directive::Log (noir-lang#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (noir-lang#77) feat: Preprocess methods for ACVM interface (noir-lang#71) expose acir_field through acir (noir-lang#75) chore(acvm): rename remaining references to gadget calls (noir-lang#76) feat: Add Log Directive (noir-lang#61) blackbox to black_box (noir-lang#72) feat(ci)!: add spellchecker (noir-lang#73)
TomAFrench
added a commit
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (#69) add tests for `from_hex` and `to_hex` (#85) improve field formatting (#84) chore(ci): Leverage reusable workflows (#81) fix clippy (#82) 0.4.1 Release remove duplicated match statement for Directive::Log (#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (#77) feat: Preprocess methods for ACVM interface (#71) expose acir_field through acir (#75) chore(acvm): rename remaining references to gadget calls (#76) feat: Add Log Directive (#61) blackbox to black_box (#72) feat(ci)!: add spellchecker (#73)
TomAFrench
added a commit
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (#69) add tests for `from_hex` and `to_hex` (#85) improve field formatting (#84) chore(ci): Leverage reusable workflows (#81) fix clippy (#82) 0.4.1 Release remove duplicated match statement for Directive::Log (#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (#77) feat: Preprocess methods for ACVM interface (#71) expose acir_field through acir (#75) chore(acvm): rename remaining references to gadget calls (#76) feat: Add Log Directive (#61) blackbox to black_box (#72) feat(ci)!: add spellchecker (#73)
TomAFrench
added a commit
that referenced
this pull request
Feb 10, 2023
* master: feat: Update Arkworks' dependencies on `acir_field` (#69) add tests for `from_hex` and `to_hex` (#85) improve field formatting (#84) chore(ci): Leverage reusable workflows (#81) fix clippy (#82) 0.4.1 Release remove duplicated match statement for Directive::Log (#79) 0.4.0 Release update changelog feat(acvm): Directive for sorting networks (#77) feat: Preprocess methods for ACVM interface (#71) expose acir_field through acir (#75) chore(acvm): rename remaining references to gadget calls (#76) feat: Add Log Directive (#61) blackbox to black_box (#72) feat(ci)!: add spellchecker (#73)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
No issue quick fix I noticed
Resolves (link to issue)
Description
We had an unreachable match case in
solve_directivesdue to duplicatedDirective::LoglogicSummary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)