This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
feat(acvm)!: switch to accepting public inputs as a map #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
verify_from_cs
andverify_with_vk
now accept aBTreeMap<Witness, FieldElement>
. This is used in combination with the explicit ABI->Witness map in noir-lang/noir#851 to handle multiple ABI fields (params + return value) being mapped to the same witness index semantically.I've reverted the change to
verify_from_cs
as we should leave it unchanged until we remove it.Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)