Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acvm)!: switch to accepting public inputs as a map #96

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Feb 15, 2023

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves (link to issue)

Description

Summary of changes

verify_from_cs and verify_with_vk now accept a BTreeMap<Witness, FieldElement>. This is used in combination with the explicit ABI->Witness map in noir-lang/noir#851 to handle multiple ABI fields (params + return value) being mapped to the same witness index semantically.

I've reverted the change to verify_from_cs as we should leave it unchanged until we remove it.

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@TomAFrench TomAFrench changed the title feat(acvm): switch to accepting public inputs as a map [DO NOT MERGE] feat(acvm): switch to accepting public inputs as a map Feb 21, 2023
@TomAFrench TomAFrench changed the title feat(acvm): switch to accepting public inputs as a map feat(acvm)!: switch to accepting public inputs as a map Feb 21, 2023
@TomAFrench TomAFrench merged commit f57ba57 into master Feb 22, 2023
@github-actions github-actions bot mentioned this pull request Feb 22, 2023
@TomAFrench TomAFrench deleted the public-inputs-map branch February 22, 2023 19:43
@TomAFrench
Copy link
Member Author

Approved by @kevaundray in person (also a reminder to set up branch protection!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant