This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
chore: raise an issue when nightly build fails #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
raise-issue-on-failing-nightly
branch
2 times, most recently
from
0093c38
to
5cea614
Compare
TomAFrench
commented
Mar 10, 2023
TomAFrench
force-pushed
the
raise-issue-on-failing-nightly
branch
from
5cea614
to
01a8eaa
Compare
TomAFrench
force-pushed
the
raise-issue-on-failing-nightly
branch
from
01a8eaa
to
476abd7
Compare
|
Looks like this is triggering even when the tests pass now for some reason. Will investigate later. |
|
Seems like moving the condition inside the braces worked. |
Closed
phated
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Sorry for the delay. I wanted to look over the action. In general, I think we should fork an audit each action we pull into the organization, especially ones that are provided our secrets.
Alternatively, we can use the GitHub CLI which is install in each runner. Something like: https://cli.github.com/manual/gh_issue_create
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had failing nightly builds for a couple of weeks now but I didn't notice it until today due to us not having monitoring set up.
As a simple version of this, the build workflows now open an issue when they fail to ping us. I've added a couple of people to be assigned based on who tends to tinker with CI the most, if you'd rather be removed from this then let me know.