Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Document slice builtins: push_front, pop_back, pop_front, insert, remove #222

Closed
github-actions bot opened this issue Jul 7, 2023 · 3 comments · Fixed by #246
Closed

Document slice builtins: push_front, pop_back, pop_front, insert, remove #222

github-actions bot opened this issue Jul 7, 2023 · 3 comments · Fixed by #246
Assignees
@critesjosh @vezenovm
Labels
migrated

Comments

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Document PR #1888 on the Noir repository.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 7, 2023
@Savio-Sou Savio-Sou changed the title Document Noir PR 1888 Document slice builtins: push_front, pop_back, pop_front, insert, remove Jul 10, 2023
@critesjosh
Copy link
Collaborator

@vezenovm do you want help documenting these updates?

@vezenovm
Copy link
Contributor

do you want help documenting these updates?

That would be very helpful. If you need something from me please let me know. I made sure to comment slice.nr in the stdlib with descriptions of the methods just haven't had a chance to do it on the docs

@critesjosh critesjosh mentioned this issue Jul 17, 2023
Merged
@critesjosh
Copy link
Collaborator

thanks, the comments and the tests were super helpful. just requested your review on the PR

@critesjosh critesjosh self-assigned this Jul 17, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@critesjosh critesjosh

@vezenovm vezenovm

Labels
migrated
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new slice methods noir-lang/docs
2 participants
@critesjosh @vezenovm