Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Add multiple slice builtins #1888

Merged
merged 3 commits into from
Jul 10, 2023
Merged

feat(stdlib): Add multiple slice builtins #1888

merged 3 commits into from
Jul 10, 2023

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Jul 7, 2023

Description

This PR adds slice builtins for push_front, pop_back, pop_front, insert, and remove.

Problem*

This is indirectly related with #1556 and implementing vectors. The original slices PR only included push_back and a full Vec type needs more slice builtins like the ones included in this PR.

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from jfecher July 7, 2023 14:47
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Closed
@vezenovm vezenovm requested a review from jfecher July 10, 2023 14:31
jfecher
jfecher approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher enabled auto-merge July 10, 2023 15:13
@jfecher jfecher added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit 008a16b Jul 10, 2023
@jfecher jfecher deleted the mv/slice-builtins branch July 10, 2023 15:24
@kevaundray kevaundray mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vezenovm @jfecher