Skip to content

Commit

Permalink
fix: fixup exports from noir_wasm (#4022)
Browse files Browse the repository at this point in the history
# Description

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*

The ordering on `exports` is important plus we have `types` missing
which was causing issues in `aztec-packages`.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
TomAFrench authored Jan 11, 2024
1 parent 37272b9 commit 358cdd2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/test-js-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: noir_wasm
path: ./compiler/wasm
path: |
./compiler/wasm/dist
./compiler/wasm/build
retention-days: 3

build-acvm-js:
Expand Down
1 change: 0 additions & 1 deletion compiler/wasm/.gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
noir-script/target
dist
build
5 changes: 3 additions & 2 deletions compiler/wasm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
"types": "./dist/types/src/index.d.cts",
"exports": {
"node": "./dist/node/main.js",
"default": "./dist/web/main.mjs",
"import": "./dist/web/main.mjs",
"require": "./dist/node/main.js"
"require": "./dist/node/main.js",
"types": "./dist/types/src/index.d.cts",
"default": "./dist/web/main.mjs"
},
"files": [
"dist",
Expand Down

0 comments on commit 358cdd2

Please sign in to comment.