feat: add integration tests for bitshift operators (#1272)

* chore: add test for bitshift operators

* chore: update error message to flag up that runtime shifts are not implemented yet

* chore: split runtime and comptime bitshift tests

* chore: replace `constrain` with `assert()`

crates/nargo_cli/tests/test_data/bit_shifts_comptime/Nargo.toml

@@ -0,0 +1,5 @@
+[package]
+authors = [""]
+compiler_version = "0.1"
+
+[dependencies]

crates/nargo_cli/tests/test_data/bit_shifts_comptime/Prover.toml

@@ -0,0 +1 @@
+x = 64

crates/nargo_cli/tests/test_data/bit_shifts_comptime/src/main.nr

@@ -0,0 +1,13 @@
+fn main(x: u64) {
+	let two: u64 = 2;
+	let three: u64 = 3;
+
+	// comptime shifts on comptime values
+	assert(two << 2 == 8);
+	assert((two << 3) / 8 == two);
+	assert((three >> 1) == 1);
+
+	// comptime shifts on runtime values
+	assert(x << 1 == 128);
+	assert(x >> 2 == 16);
+}

crates/nargo_cli/tests/test_data/bit_shifts_runtime/Nargo.toml

@@ -0,0 +1,5 @@
+[package]
+authors = [""]
+compiler_version = "0.1"
+
+[dependencies]

crates/nargo_cli/tests/test_data/bit_shifts_runtime/Prover.toml

@@ -0,0 +1,2 @@
+x = 64
+y = 1

crates/nargo_cli/tests/test_data/bit_shifts_runtime/src/main.nr

@@ -0,0 +1,12 @@
+fn main(x: u64, y: u64) {
+	// These are currently unimplemented and panic with "ShiftLeft and ShiftRight operations with shifts which are only known at runtime are not yet implemented."
+	// See: https://github.com/noir-lang/noir/issues/1265
+
+	// runtime shifts on comptime values
+	assert(64 << y == 128);
+	assert(64 >> y == 32);
+
+	// runtime shifts on runtime values
+	assert(x << y == 128);
+	assert(x >> y == 32);
+}

crates/nargo_cli/tests/test_data/config.toml

@@ -2,7 +2,7 @@
 # "1_mul", "2_div","3_add","4_sub","5_over", "6","6_array", "7_function","7","8_integration", "9_conditional", "10_slices", "assign_ex", "bool_not", "bool_or", "pedersen_check", "poseidonperm_x5_254", "poseidonsponge_x5_254", "pred_eq", "schnorr", "sha256", "tuples",
 # "array_len", "array_neq", "bit_and", "cast_bool", "comptime_array_access", "generics", "global_comptime", "main_bool_arg", "main_return", "merkle_insert", "modules", "modules_more", "scalar_mul", "simple_shield", "struct", "submodules",
 # Exclude "poseidonsponge_x5_254" and "sha2_byte" due to relatively long computation time and "sha2_blocks" due to very long computation time.
-exclude = ["comptime_fail", "poseidonsponge_x5_254", "sha2_blocks", "sha2_byte"]
+exclude = ["bit_shifts_runtime", "comptime_fail", "poseidonsponge_x5_254", "sha2_blocks", "sha2_byte"]
 
 
 # List of tests (as their directory name in test_data) expecting to fail: if the test pass, we report an error.

crates/noirc_evaluator/src/ssa/acir_gen/operations/binary.rs

@@ -238,7 +238,7 @@ pub(crate) fn evaluate(
                 };
                 InternalVar::from(bitwise_result)
             }
-            BinaryOp::Shl | BinaryOp::Shr(_) => unreachable!("ICE: ShiftLeft and ShiftRight are replaced by multiplications and divisions in optimization pass."),
+            BinaryOp::Shl | BinaryOp::Shr(_) => todo!("ShiftLeft and ShiftRight operations with shifts which are only known at runtime are not yet implemented."),
             i @ BinaryOp::Assign => unreachable!("Invalid Instruction: {:?}", i),
         };
     Some(binary_output)