Skip to content

Commit

Permalink
chore(ci): deny wildcard dependencies (#2702)
Browse files Browse the repository at this point in the history
  • Loading branch information
TomAFrench authored Sep 14, 2023
1 parent 8d464a6 commit 8a27b38
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 22 deletions.
2 changes: 0 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions compiler/wasm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,5 @@ gloo-utils = { version = "0.1", features = ["serde"] }
log = "0.4.17"
wasm-logger = "0.2.0"

# This is an unused dependency, we are adding it
# so that we can enable the js feature in getrandom.
getrandom = { version = "*", features = ["js"] }

[build-dependencies]
build-data = "0.1.3"
7 changes: 0 additions & 7 deletions compiler/wasm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ use serde::{Deserialize, Serialize};
use std::str::FromStr;
use wasm_bindgen::prelude::*;

// This dependency is not used. We import it
// to bypass the `unused_crate_dependencies` lint.
//
// It is being imported as we get errors regarding the
// js feature not being enabled.
use getrandom as _;

mod circuit;
mod compile;

Expand Down
4 changes: 2 additions & 2 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ notice = "warn"
# Lint level for when multiple versions of the same crate are detected
multiple-versions = "warn"
# Lint level for when a crate version requirement is `*`
wildcards = "allow"
wildcards = "warn"
highlight = "all"
# List of crates to deny
deny = [
Expand Down Expand Up @@ -97,4 +97,4 @@ unknown-registry = "warn"
unknown-git = "deny"
allow-git = [
"https://github.com/jfecher/chumsky"
]
]
4 changes: 0 additions & 4 deletions tooling/noirc_abi_wasm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ gloo-utils = { version = "0.1", features = ["serde"] }

js-sys = "0.3.62"

# This is an unused dependency, we are adding it
# so that we can enable the js feature in getrandom.
getrandom = { version = "*", features = ["js"] }

[build-dependencies]
build-data = "0.1.3"

Expand Down
3 changes: 0 additions & 3 deletions tooling/noirc_abi_wasm/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
#![warn(unreachable_pub)]
#![warn(clippy::semicolon_if_nothing_returned)]

// See Cargo.toml for explanation.
use getrandom as _;

use acvm::acir::native_types::WitnessMap;
use iter_extended::try_btree_map;
use noirc_abi::{errors::InputParserError, input_parser::InputValue, Abi, MAIN_RETURN_NAME};
Expand Down

0 comments on commit 8a27b38

Please sign in to comment.