feat: Report compilation warnings before errors (#2398)

Co-authored-by: jfecher <jake@aztecprotocol.com>
noir-lang · Aug 23, 2023 · a1d1267 · a1d1267
1 parent 707685c
commit a1d1267
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/crates/noirc_errors/src/reporter.rs b/crates/noirc_errors/src/reporter.rs
@@ -115,6 +115,10 @@ pub fn report_all(
     diagnostics: &[FileDiagnostic],
     deny_warnings: bool,
 ) -> ReportedErrors {
+    // Report warnings before any errors
+    let (mut diagnostics, mut errors): (Vec<_>, _) =
+        diagnostics.iter().partition(|item| item.diagnostic.is_warning());
+    diagnostics.append(&mut errors);
     let error_count =
         diagnostics.iter().map(|error| error.report(files, deny_warnings) as u32).sum();