Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assigning to tuple fields #1318

Merged
merged 5 commits into from
May 8, 2023
Merged

fix: Assigning to tuple fields #1318

merged 5 commits into from
May 8, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented May 8, 2023

Related issue(s)

Resolves #1309

Description

Summary of changes

A parser bug parsing fields using ident() instead of field_name() (which is an ident or integer literal) lead to assignment to tuple fields not being possible. This was overlooked before, as the relevant code to handle tuple-field assignments was not in the type checker either. To fix this I've merged the code that handles tuple field assignments and tuple field access (a normal a.b expression not in an LValue context) so that this will not happen again. I've also slightly improved the error message if a user accesses a tuple field that is out of bounds.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

BEGIN_COMMIT_OVERRIDE
fix: Fix parser error preventing assignments to tuple fields (#1318)
END_COMMIT_OVERRIDE

@kevaundray
Copy link
Contributor

Can we add a regression test for this?

@jfecher
Copy link
Contributor Author

jfecher commented May 8, 2023

Added a short regression test

@kevaundray kevaundray enabled auto-merge May 8, 2023 19:45
@kevaundray kevaundray added this pull request to the merge queue May 8, 2023
Merged via the queue into master with commit 460568e May 8, 2023
@kevaundray kevaundray deleted the jf/tuple-field-parsing branch May 8, 2023 20:13
TomAFrench added a commit that referenced this pull request May 17, 2023
* master: (66 commits)
  feat(nargo)!: retire print-acir in favour of flag (#1328)
  chore(ssa): enable cse for assert (#1350)
  chore(ssa refactor): Add basic instruction simplification (#1329)
  chore(noir): Release 0.6.0 (#1279)
  feat: enable to_radix for any field element (#1343)
  chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337)
  chore!: Update to acvm 0.11.0 (#1322)
  feat: Add ECDSA secp256k1 builtin test (#1294)
  chore: add support for encoding/decoding inputs from JSON (#1325)
  feat: Issue an error when attempting to use a `return` expression (#1330)
  chore(ssa refactor): Fix inlining bug (#1335)
  fix: to-bits and to-radix for > 128 bits (#1312)
  chore(parser): Parser error optimisation (#1292)
  chore(ssa refactor): Implement function inlining (#1293)
  chore: fix installation link in readme (#1326)
  chore: fix installation link in readme (#1326)
  feat(stdlib): Add keccak (#1249)
  fix: Parsing nested generics (#1319)
  chore(ssa refactor): Document some SSA-gen functions (#1321)
  fix: Assigning to tuple fields (#1318)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning to a tuple member within if fails
2 participants