-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Update to acvm 0.11.0 #1322
Conversation
I've renamed the type parameters to |
chore!: Split filesystem errors off from CliError chore!: Make all run functions take a backend and pass it from the CLI entry
I've updated this to use the commit for the 0.1.0 release of acvm-backend-barretenberg pending noir-lang/acvm-backend-barretenberg#178 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've made a couple of tweaks at the end so will let you have last look.
I'm not a fan of how the errors require CliError
to be generic as it seems like we're taking on extra complexity (type parameters and casting traits) for not much benefit. I'd like to make a separate proposal which imo simplifies things later.
I'm fine with your try_vecmap changes, even though I often don't like to introduce unnecessary lambdas into rust code.
Happy to take a look, but I experimented with different options and the only two ways I could find to make This still needs an approval from someone that isn't me. |
* master: (66 commits) feat(nargo)!: retire print-acir in favour of flag (#1328) chore(ssa): enable cse for assert (#1350) chore(ssa refactor): Add basic instruction simplification (#1329) chore(noir): Release 0.6.0 (#1279) feat: enable to_radix for any field element (#1343) chore(ssa refactor): Simplify inlining pass and fix inlining failure (#1337) chore!: Update to acvm 0.11.0 (#1322) feat: Add ECDSA secp256k1 builtin test (#1294) chore: add support for encoding/decoding inputs from JSON (#1325) feat: Issue an error when attempting to use a `return` expression (#1330) chore(ssa refactor): Fix inlining bug (#1335) fix: to-bits and to-radix for > 128 bits (#1312) chore(parser): Parser error optimisation (#1292) chore(ssa refactor): Implement function inlining (#1293) chore: fix installation link in readme (#1326) chore: fix installation link in readme (#1326) feat(stdlib): Add keccak (#1249) fix: Parsing nested generics (#1319) chore(ssa refactor): Document some SSA-gen functions (#1321) fix: Assigning to tuple fields (#1318) ...
Related issue(s)
Resolves #1301
Description
Summary of changes
This updates the project to ACVM 0.11.0
This is the version of ACVM that introduced the Result return type to many of the functions on the Backend trait. This allows us to better surface errors from backends—and as such, aztec_backend has been updated to return results for almost all errors (the only unwraps remaining are in the merkle implementation).
This version of ACVM also introduced keccak into the constraint system, so we needed to upgrade barretenberg also. This may cause the same OOM error that the other Keccak PR is exhibiting.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Documentation needs
Additional context