Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dynamic array in acir gen efficient #2014

Closed
kevaundray opened this issue Jul 24, 2023 · 0 comments · Fixed by #2142
Closed

Make dynamic array in acir gen efficient #2014

kevaundray opened this issue Jul 24, 2023 · 0 comments · Fixed by #2142
Assignees
Labels
enhancement New feature or request ssa

Comments

@kevaundray
Copy link
Contributor

Problem

Related to #1969 (comment)

The way we are generating acir opcodes for dynamic arrays follows too closely to the SSA IR. ie for each array_set, we are creating a new array and then copying over the old array into the new array and then setting just one value in that array at the specified index.

Happy Case

A rough solution would see an array_set and change the pointer to look at the new array's ID as the pointer for the new array and then only modify one value in that array.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ssa
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants