-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic arrays for experimental-ssa #1969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
reviewed
Jul 21, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Outdated
Show resolved
Hide resolved
kevaundray
reviewed
Jul 21, 2023
kevaundray
reviewed
Jul 21, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
kevaundray
reviewed
Jul 24, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Outdated
Show resolved
Hide resolved
kevaundray
reviewed
Jul 24, 2023
This was referenced Jul 24, 2023
kevaundray
approved these changes
Jul 24, 2023
@kevaundray / @guipublic seems that this is a bug fix? What needs to be documented exactly? |
I don't think it is needed to be documented, as it is adding the dynamic arrays feature to the experimental-sea. It should be transparent for the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Test case array-dynamic is now passing
Resolves #1964
Summary*
The PR is now ready for review:
feat: add support for atomic memory opcodes acvm-backend-barretenberg#232
feat!: atomic memory opcodes acvm#447
For non-const index on array operation, we generate a new ACIR opcode corresponding to the operation. This allows ACVM solver to perform stepwise/in-order solving. The backend can easily create the block constraints from them.
Because an array-set generates a new ssa array, we need to copy the array into a new one also in acir-gen. This could be optimised out in case the array we copy is not re-used afterwards. This new array has no more values associated to it so it is mapped to a new AcirArray type.
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmt
on default settings.