Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope contents: write permission more closely to uploading artifacts in publish.yml #2263

Open
TomAFrench opened this issue Aug 10, 2023 · 1 comment
Open

Scope contents: write permission more closely to uploading artifacts in publish.yml #2263

TomAFrench opened this issue Aug 10, 2023 · 1 comment
Labels
CI enhancement New feature or request good first issue Good for newcomers
Milestone
1.0+

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Aug 10, 2023 •
edited
Loading

Currently the entire publish.yml workflow has write permissions over the repository. We only need this for uploading artifacts to the release so we should try and scope it more narrowly.

#2211 (comment)
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Aug 10, 2023
@kevaundray kevaundray added the CI label Aug 14, 2023
@Savio-Sou Savio-Sou added enhancement New feature or request P-LOW labels Nov 2, 2023
@Savio-Sou
Copy link
Collaborator

Assigning P-LOW as it seems like a nice to have / good practice.

Guessing E-LOW.

@kevaundray kevaundray added the good first issue Good for newcomers label Jan 15, 2024
@kevaundray kevaundray added this to the 1.1 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI enhancement New feature or request good first issue Good for newcomers
Projects
Noir
Status: 📋 Backlog
Milestone
1.0+
Development

No branches or pull requests
3 participants
@TomAFrench @kevaundray @Savio-Sou