Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Merge in contents of build-nargo repository #2211

Merged
merged 28 commits into from
Aug 10, 2023
Merged

chore: Merge in contents of build-nargo repository #2211

merged 28 commits into from
Aug 10, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Aug 8, 2023 •
edited
Loading

Description

Problem*

Resolves #2188

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member Author

TomAFrench commented Aug 8, 2023 •
edited
Loading

This PR is currently in draft as I perform testing, once I'm happy with the setup I'll restrict when it runs and re-enable alerts/publishing.

@TomAFrench
Copy link
Member Author

We need to clone the noir repo into the ./noir path as we need to be able to place the wasm binary outside of the repo to keep the repo clean.

@kevaundray
Copy link
Contributor

In a separate PR, we can make it such that each night, a new tag is created using the date like in Rust such that we can do the following: noirup -v 2023-08-08

@kevaundray
Copy link
Contributor

Note: we have quite a bit of complexity from needing to cross compile barretenberg which should be minimized once we use prebuilt binaries

@TomAFrench
Copy link
Member Author

This should be ready now.

@TomAFrench TomAFrench marked this pull request as ready for review August 8, 2023 17:32
kevaundray
kevaundray reviewed Aug 8, 2023
View reviewed changes
.github/Cross.toml Outdated Show resolved Hide resolved
kevaundray
kevaundray previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, can change to GITHUB_TOKEN in a separate PR since there are concerns

phated
phated suggested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a couple more things and a clarification.

.github/Cross.toml Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
release-tests/package.json Show resolved Hide resolved
@TomAFrench TomAFrench mentioned this pull request Aug 10, 2023
Open
phated
phated previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts on future improvements. It'd be nice to have all these as issues 🙏

.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
release-tests/package.json Outdated Show resolved Hide resolved
release-tests/test/6_array.test.js Show resolved Hide resolved
@TomAFrench TomAFrench mentioned this pull request Aug 10, 2023
Closed
@TomAFrench
Copy link
Member Author

Issue for comments related to release-tests opened here #2262

@TomAFrench TomAFrench mentioned this pull request Aug 10, 2023
Open
@TomAFrench TomAFrench mentioned this pull request Aug 10, 2023
Closed
@TomAFrench TomAFrench requested a review from phated August 10, 2023 18:58
@TomAFrench TomAFrench added this pull request to the merge queue Aug 10, 2023
@TomAFrench TomAFrench removed this pull request from the merge queue due to a manual request Aug 10, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Aug 10, 2023
Merged via the queue into master with commit d04f7d5 Aug 10, 2023
7 checks passed
@TomAFrench TomAFrench deleted the build-workflow branch August 10, 2023 19:38
TomAFrench added a commit that referenced this pull request Aug 11, 2023
@TomAFrench
Merge branch 'master' into constant-brillig-execution
34b7982 
* master: (29 commits)
  feat(nargo): Add support for contracts in `nargo check` (#2267)
  chore(ci): Name wasm job more clearly (#2269)
  chore(ci): Create cache key with consideration to target (#2273)
  chore(ci): Run publish workflow against PRs (#2268)
  chore: Merge in contents of `build-nargo` repository (#2211)
  fix(lsp): Improve dependency resolution in context of `Nargo.toml` (#2226)
  chore: Remove unnecessary duplication in how we test Noir compiler (#2248)
  fix: properly capture lvalues in closure environments (#2120) (#2257)
  fix: Optimize contracts built by `nargo info` (#2259)
  chore: impl Display for DebugType (#2258)
  chore: update `noir_wasm` build process to match `acvm_js` (#2067)
  feat: Implement traits - parser support #2094 (#2230)
  chore: Refactor DefCollector duplicate errors (#2231)
  chore: Address clippy warnings (#2246)
  feat: Support `contract` package type in `nargo info` command (#2249)
  feat: Add slice append (#2241)
  chore: Bump `async-lsp` to v0.0.5 (#2186)
  chore: Move the remaining `nargo_cli` lib funcs into `nargo` crate (#2225)
  chore: Add test for eddsa (#2237)
  chore: Split `Nargo.toml` operations into separate package (#2224)
  ...
TomAFrench added a commit that referenced this pull request Aug 11, 2023
@TomAFrench
Merge branch 'master' into assert-eq-builtin
db5cd70 
* master:
  feat(nargo): Add support for contracts in `nargo check` (#2267)
  chore(ci): Name wasm job more clearly (#2269)
  chore(ci): Create cache key with consideration to target (#2273)
  chore(ci): Run publish workflow against PRs (#2268)
  chore: Merge in contents of `build-nargo` repository (#2211)
  fix(lsp): Improve dependency resolution in context of `Nargo.toml` (#2226)
  chore: Remove unnecessary duplication in how we test Noir compiler (#2248)
  fix: properly capture lvalues in closure environments (#2120) (#2257)
  fix: Optimize contracts built by `nargo info` (#2259)
  chore: impl Display for DebugType (#2258)
  chore: update `noir_wasm` build process to match `acvm_js` (#2067)
  feat: Implement traits - parser support #2094 (#2230)
  chore: Refactor DefCollector duplicate errors (#2231)
  chore: Address clippy warnings (#2246)
  feat: Support `contract` package type in `nargo info` command (#2249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@kevaundray kevaundray kevaundray left review comments

@kobyhallx kobyhallx Awaiting requested review from kobyhallx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull build-nargo in noir repo Integrate noir-lang/build-nargo into this repository
4 participants
@TomAFrench @kevaundray @phated @kobyhallx