-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apostrophes are not permitted in test attributes #3372
Comments
not too important but i found this is also the case with some of these characters happy to pr for some of the common punctuation if yall are open to it
edit: im on 0.19.4 currently |
Great catch -- Please feel free to make a PR! |
# Description was onboarding this morning to tackle [a quick issue over here](#3372) and noticed this link broke in the top level README https://github.com/noir-lang/noir?tab=readme-ov-file#working-on-this-project ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. Co-authored-by: kevaundray <kevtheappdev@gmail.com>
# Description spotted an issue with punctuation inside a `#[test(should_fail_with = "")]` block ([comment on original issue](#3372 (comment))) ## Problem\* Resolves #3372 (an extension of this original issue) ## Summary\* I built off of the original work done over here #3374 but simplified things down to just cover all common punctuation ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>
Aim
Expected Behavior
It to compile the test
Bug
We get "Malformed function attribute" due to the
'
(apostrophe) being used.To Reproduce
Installation Method
None
Nargo Version
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response
The text was updated successfully, but these errors were encountered: