Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ignored tests #3802

Closed
kevaundray opened this issue Dec 14, 2023 · 2 comments · Fixed by #4050
Closed

Re-enable ignored tests #3802

kevaundray opened this issue Dec 14, 2023 · 2 comments · Fixed by #4050
Assignees
@TomAFrench
Labels
enhancement New feature or request
Milestone
1.0

Comments

@kevaundray
Copy link
Contributor

Problem

Grep #[ignore] to see tests which are ignored

Happy Case

re-enable them

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added enhancement New feature or request P-LOW labels Dec 14, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 14, 2023
@TomAFrench
Copy link
Member

These tests pass but I think they need to be checked that they're meaningful at the same time as reenabling them.

@kevaundray
Copy link
Contributor Author

These tests pass but I think they need to be checked that they're meaningful at the same time as reenabling them.

Yep good point!

@kevaundray kevaundray added this to the 1.0 milestone Jan 15, 2024
@TomAFrench TomAFrench mentioned this issue Jan 16, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2024
@TomAFrench
chore: reenable integration tests in ACVM (#4050)
a3b162b 
# Description

## Problem\*

Resolves #3802

## Summary\*

This PR enables these ignored tests.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomAFrench TomAFrench

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

chore: reenable integration tests in ACVM noir-lang/noir
3 participants
@TomAFrench @kevaundray @Savio-Sou