Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate bigint structures per moduli #4257

Closed
Tracked by #510
guipublic opened this issue Feb 5, 2024 · 1 comment · Fixed by #4390
Closed
Tracked by #510

Differentiate bigint structures per moduli #4257

guipublic opened this issue Feb 5, 2024 · 1 comment · Fixed by #4390
Assignees
@guipublic
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

BB supports foreign field arithmetic (aka bigfield, or bigint in Noir context) but only for 6 different moduli.
In order to avoid mixing bigint operations between different moduli, we should use a different structure for each modulus.

Happy Case

Remove specialised functions secpk1_...() and use instead a bigint_secpk1.. struct which implements the bigint trait.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response
@guipublic guipublic added the enhancement New feature or request label Feb 5, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
@Savio-Sou Savio-Sou moved this from 📋 Backlog to 🏗 In progress in Noir Feb 9, 2024
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this issue Feb 15, 2024
@guipublic
chore: add struct for each bigint modulus (#4422)
a2942b7 
Resolves Noir issue noir-lang/noir#4257

The PR simply adds one struct per modulus, so that the user cannot mix
them.
@michaelelliot michaelelliot mentioned this issue Feb 20, 2024
Closed
@Savio-Sou Savio-Sou mentioned this issue Feb 22, 2024
Closed
@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Feb 23, 2024 •
edited
Loading

Was tackled in AztecProtocol/aztec-packages#4422 and will be closed with #4390.

@Savio-Sou Savio-Sou linked a pull request Feb 23, 2024 that will close this issue
feat: Sync from aztec-packages #4390
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guipublic guipublic

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Sync from aztec-packages noir-lang/noir
2 participants
@guipublic @Savio-Sou