Make types in SSA binary operations match

[sirasistant]

Problem

Upcoming changes in brillig will require that the types of both operands in binary operations match. Even though in noir we enforce matching types, we don't in SSA, and the SSA codegen sometimes issues binary operations where the types of LHS and RHS don't match.

Happy Case

This assertion shouldn't fail in tests:

    pub(crate) fn insert_binary(
        &mut self,
        lhs: ValueId,
        operator: BinaryOp,
        rhs: ValueId,
    ) -> ValueId {
        assert_eq!(
            self.type_of_value(lhs),
            self.type_of_value(rhs),
            "ICE - Binary operands must have the same type"
        );

Alternatives Considered

We could upcast in the codegen as we do now. But brillig for the AVM won't support euclidean divisions of field types, so this would still be an issue. Also, it makes sense for SSA to respect this binary operation rule as noir does, and it would simplify codegens after SSA.

Additional Context

Current cases where this check is blowing up

Beta Give feedback

1. codegen_array_index
2. codegen_slice_access_check
3. insert_shift_right
4. make_offset
5. codegen_for
6. assign_lvalue_index

Initial tests failing with this check:

failures:
    tests::compile_failure_radix_non_constant_length
    tests::compile_failure_slice_access_failure
    tests::compile_failure_slice_insert_failure
    tests::compile_failure_slice_remove_failure
    tests::compile_success_empty_brillig_integer_binary_operations
    tests::compile_success_empty_closure_explicit_types
    tests::compile_success_empty_conditional_regression_547
    tests::compile_success_empty_conditional_regression_to_bits
    tests::compile_success_empty_ec_baby_jubjub
    tests::compile_success_empty_field_comparisons
    tests::compile_success_empty_regression_3635
    tests::compile_success_empty_str_as_bytes
    tests::compile_success_empty_to_bits
    tests::compile_success_empty_vectors
    tests::execution_success_6
    tests::execution_success_6_array
    tests::execution_success_7_function
    tests::execution_success_array_dynamic
    tests::execution_success_bit_shifts_comptime
    tests::execution_success_bit_shifts_runtime
    tests::execution_success_brillig_cow
    tests::execution_success_brillig_cow_assign
    tests::execution_success_brillig_hash_to_field
    tests::execution_success_brillig_loop
    tests::execution_success_brillig_oracle
    tests::execution_success_brillig_pedersen
    tests::execution_success_brillig_schnorr
    tests::execution_success_brillig_slices
    tests::execution_success_brillig_to_be_bytes
    tests::execution_success_brillig_to_bits
    tests::execution_success_brillig_to_bytes_integration
    tests::execution_success_brillig_to_le_bytes
    tests::execution_success_conditional_1
    tests::execution_success_databus
    tests::execution_success_eddsa
    tests::execution_success_hash_to_field
    tests::execution_success_integer_array_indexing
    tests::execution_success_merkle_insert
    tests::execution_success_modulus
    tests::execution_success_nested_array_in_slice
    tests::execution_success_operator_overloading
    tests::execution_success_pedersen_check
    tests::execution_success_poseidon_bn254_hash
    tests::execution_success_poseidonsponge_x5_254
    tests::execution_success_references
    tests::execution_success_regression
    tests::execution_success_schnorr
    tests::execution_success_sha2_byte
    tests::execution_success_simple_radix
    tests::execution_success_simple_shield
    tests::execution_success_simple_shift_left_right
    tests::execution_success_slice_dynamic_index
    tests::execution_success_slices
    tests::execution_success_to_be_bytes
    tests::execution_success_to_bytes_consistent
    tests::execution_success_to_bytes_integration
    tests::execution_success_to_le_bytes
    tests::execution_success_tuple_inputs
    tests::execution_success_u128
    tests::noir_test_success_field_comparisons

Current tests failing with this check:

Would you like to submit a PR for this Issue?

No

Support Needs

No response