Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verification issue with bigints and activate the doc snippet in bigint test #4530

Open
guipublic opened this issue Mar 12, 2024 · 0 comments
Open

Fix verification issue with bigints and activate the doc snippet in bigint test #4530

guipublic opened this issue Mar 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@guipublic
Copy link
Contributor

Problem

The doc snippet in the big int test (the function big_int_example(..)), from PR #4487, has been disabled because it fails verification.

Happy Case

The code should verify.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@guipublic guipublic added the enhancement New feature or request label Mar 12, 2024
@guipublic guipublic mentioned this issue Mar 13, 2024
Merged
guipublic added a commit to AztecProtocol/aztec-packages that referenced this issue Mar 19, 2024
@guipublic @TomAFrench @Rumata888
fix: set denominator to 1 during verification of dsl/big-field divisi…
253d002 
…on (#5188)

This PR solve the verification issue with bigint division in Noir:
noir-lang/noir#4530

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Rumata888 <isennovskiy@gmail.com>
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Mar 20, 2024
@guipublic @TomAFrench
@Rumata888 @AztecBot
fix: set denominator to 1 during verification of dsl/big-field divisi…
afcbb32 
…on (#5188)

This PR solve the verification issue with bigint division in Noir:
noir-lang/noir#4530

---------

Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Rumata888 <isennovskiy@gmail.com>
@guipublic guipublic mentioned this issue Apr 15, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 15, 2024
@guipublic
fix: proper field inversion for bigints (#4802)
b46d0e3 
# Description

## Problem\*

Resolves #4578. The fix for issue #4530 has also being merged back so I
also activate the related test case.

## Summary\*

Field inversion for bigints had a typo.

## Additional Context

I did not consider biguint256 since it was decided not to merge the PR.

## Documentation\*

Check one:
- [X] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [X] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guipublic