Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comptime modifier for variables/functions which only exist at compile-time #4588

Closed
Tracked by #4594
jfecher opened this issue Mar 19, 2024 · 0 comments · Fixed by #4840
Closed
Tracked by #4594

Add comptime modifier for variables/functions which only exist at compile-time #4588

jfecher opened this issue Mar 19, 2024 · 0 comments · Fixed by #4840
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Mar 19, 2024

Problem

Noir needs a comptime modifier to signal which functions/variables should be evaluated (only) at compile-time.

Happy Case

Add a comptime modifier to variables and functions.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Mar 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 19, 2024
# Description

## Problem\*

Resolves #4588

## Summary\*

Adds the `comptime` keyword which can be used around certain constructs:

- `comptime let foo = ...;` on local or global definitions
- `comptime if a { b } else { c }`
- `comptime for ... { ... }`
- `comptime { ... }`

This PR just adds these to parsing and forwards the new node types to
the frontend as necessary.

## Additional Context

The interpreter currently _does not_ handle these properly - this will
come in a separate PR. Eventually we want the interpreter to _only_
interpret comptime things where currently it interprets everything.

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant