Merge GrumpkinPoint from aztec protocol circuit types and EmbeddedCurvePoint from noir::std
#4931
Labels
enhancement
New feature or request
Comments
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 6, 2024
…5190) # Description ## Problem\* Related to #4931 ## Summary\* Replace PedersenPoint in the std lib with EmbeddedPoint ## Additional Context ## Documentation\* Check one: - [X ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
This was referenced Jun 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 19, 2024
# Description ## Problem\* Related to #4931 ## Summary\* Noir implementation for Pedersen Hash. ## Additional Context I added a derive_generators() built-in function, which only works for bn254, and then use pedersen commitments and scalar mul. ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 19, 2024
# Description ## Problem\* Related to #4931 ## Summary\* Implements Pedersen commitment in Noir and remove Pedersen Commitment, Pedersen Hash blackboxes. ## Additional Context The PR is in draft until #5217 is merged. ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [X] I have tested the changes locally. - [X] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: TomAFrench <tom@tomfren.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Currently we have the 2 types and it's making the scalar mul functions unnecessarily messy as the types are not compatible.
Happy Case
One type should be used.
Project Impact
Nice-to-have
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: