Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GrumpkinScalar out of std #4968

Closed
benesjan opened this issue May 3, 2024 · 1 comment · Fixed by AztecProtocol/aztec-packages#6240
Closed

Move GrumpkinScalar out of std #4968

benesjan opened this issue May 3, 2024 · 1 comment · Fixed by AztecProtocol/aztec-packages#6240
Labels
enhancement New feature or request

Comments

@benesjan
Copy link
Contributor

benesjan commented May 3, 2024

Problem

We have a GrumpkinScalar type in std but it is no longer used in anywhere in std and it's only used in aztec-packages. Since the type doesn't do much I think it makes sense to move it out of std (to aztec noir protocol circuits).

Note: There is also GrumpkinPrivateKey in aztec protocol circuits which is basically the same thing.

Happy Case

GrumpkinScalar not cluttering std.

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@benesjan benesjan added the enhancement New feature or request label May 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 3, 2024
@TomAFrench
Copy link
Member

Part of #4845

TomAFrench pushed a commit to AztecProtocol/aztec-packages that referenced this issue May 7, 2024
All the aztec usecases were already replaced with a GrumpkinPrivateKey
which is basically a duplicate of GrumpkinScalar.

Fixes noir-lang/noir#4968
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir May 7, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue May 8, 2024
All the aztec usecases were already replaced with a GrumpkinPrivateKey
which is basically a duplicate of GrumpkinScalar.

Fixes noir-lang/noir#4968
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
All the aztec usecases were already replaced with a GrumpkinPrivateKey
which is basically a duplicate of GrumpkinScalar.

Fixes noir-lang/noir#4968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants