Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aarch64-unknown-linux-gnu #5283

Closed
recmo opened this issue Jun 18, 2024 · 1 comment · Fixed by #5289
Closed

Support aarch64-unknown-linux-gnu #5283

recmo opened this issue Jun 18, 2024 · 1 comment · Fixed by #5289
Labels
enhancement New feature or request

Comments

@recmo
Copy link

recmo commented Jun 18, 2024

Problem

On Apple Silicon, creating a VSCode dev-container and running:

$ curl -L https://raw.githubusercontent.com/noir-lang/noirup/main/install | bash
[...]
$ source /home/node/.bashrc
$ noirup
noirup: installing nargo (latest stable)
noirup: downloading latest nargo to '/home/node/.nargo/bin'
############################################################################################################################################################################################################################################### 100.0%

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
noirup: done

On noirup line 132 it curls the URL https://github.com/noir-lang/noir/releases/latest/download/nargo-aarch64-unknown-linux-gnu.tar.gz, which returns Not Found. Note that Not Found is not a valid gzipped-tarball.

This will likely also affect the people running Linux on Apple Silicon or other aarch64 architectures.

Happy Case

Very happy: noirup installs working nargo.

Not sad: noirup returns approriate error message explaining the unsuported platform.

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@recmo recmo added the enhancement New feature or request label Jun 18, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 18, 2024
@TomAFrench
Copy link
Member

Hi @recmo,

We actually used to support aarch64-unknown-linux-gnu but had to remove support due to barretenberg dropping support for it. We've separated barretenberg more cleanly from the compiler now so we should be able to start publishing releases for this target again.

I've made a PR to start publishing these builds again but could you help test this by downloading the artifact from the publish workflow on that PR and giving it a whirl?

Note that barretenberg still doesn't support aarch64-unknown-linux-gnu so you won't be able to create/verify proofs using it but you'll be able to compile, run and test Noir code (and use any other compatible backend which does support this architecture on linux.

github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
# Description

## Problem\*

Resolves #5283 

## Summary\*

This PR adds `aarch64-unknown-linux-gnu` to the list of targets we build
for so `noirup` can serve it.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants