Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert a Type object into a token stream #5309

Closed
jfecher opened this issue Jun 21, 2024 · 0 comments · Fixed by #5326
Closed

Convert a Type object into a token stream #5309

jfecher opened this issue Jun 21, 2024 · 0 comments · Fixed by #5326
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Jun 21, 2024

Aim

We'll need some way to convert a Type into a Quoted object to be able to splice it into another quoted token stream.

Expected Behavior

This conversion should ideally be automatic so that:

comptime fn foo(typ: Type, code: Quoted) -> Quoted {
    quote {
        let _: $typ = $code;
    }
}

Works without needing to call let typ = typ.into_quoted() or similar.

Bug

Currently the conversion used just calls typ.to_string() then lexes the string, but this doesn't work for type variables and seems to tightly coupled.

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Jun 21, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 25, 2024
# Description

## Problem\*

Resolves #5309

## Summary\*

Fixes the tokenization of types by converting them to a new `QuotedType`
token. We can get the original (resolved) type from this token so that
we don't need to re-resolve a type after it is inserted into a macro's
token stream. A QuotedType token holds onto an ID for the type rather
than the type itself since our `Type` type does not implement Send or
Sync, which is required through ParseError and UnresolvedTypeData.

## Additional Context

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant