Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Support struct rename #5352

Closed
Tracked by #1582
TomAFrench opened this issue Jun 28, 2024 · 0 comments
Closed
Tracked by #1582

LSP: Support struct rename #5352

TomAFrench opened this issue Jun 28, 2024 · 0 comments
Assignees
@asterite
Labels
lsp Language Server Protocol

Comments

@TomAFrench
Copy link
Member

TomAFrench commented Jun 28, 2024 •
edited
Loading

PR #4294 adds support for renaming all references to a function however it does not support other items such as structs: #4294 (comment)

We should add support for this.
@TomAFrench TomAFrench mentioned this issue Jun 28, 2024
Closed
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jun 28, 2024
@TomAFrench TomAFrench added the lsp Language Server Protocol label Jun 28, 2024
@TomAFrench TomAFrench mentioned this issue Jun 28, 2024
Merged
5 tasks
@asterite asterite mentioned this issue Jul 1, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
@asterite @kobyhallx
@jfecher @TomAFrench
feat: lsp rename struct (#5380)
ee8b0cd 
# Description

## Problem

Resolves #5352

## Summary

Based on top of #4294

Renames all references to structs, either in constructors, patterns,
function parameters or its definition.

Let me know if there's another place where struct names can show up!


https://github.com/noir-lang/noir/assets/209371/ff12f9df-0110-4a52-8b0d-c9a5fc735d81

## Additional Context

None.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Koby <kobyhall@proton.me>
Co-authored-by: Koby Hall <102518238+kobyhallx@users.noreply.github.com>
Co-authored-by: Jake Fecher <jfecher11@gmail.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <tom@tomfren.ch>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asterite asterite

Labels
lsp Language Server Protocol
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asterite @TomAFrench