Let LSP "go to definition" work in path segments #5405
Labels
enhancement
New feature or request
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 4, 2024
# Description ## Problem Resolves #5405 ## Summary Now clicking on module segments works as expected. https://github.com/noir-lang/noir/assets/209371/e8968eea-ad0b-4d85-9500-db31e46009a0 ## Additional Context ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
"Go to definition" currently doesn't work for path segments. For example if you have
use foo::barand click onfoo, it doesn't take you to thefoomodule. Similarly, if you have a call likefoo::bar(), clicking onfoodoesn't do anything. Then, if you havemod foo;, clicking onfoodoesn't do anything either.Happy Case
Clicking on any part of a path, be it in a
modstatement,usestatement, a call or a reference to a type, etc., should take you to the module declaration. This should work both for modules declared in a file as well as inline modules (mod foo { ... }).Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered: