Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: support rename/find-all-references for struct members #5459

Closed
asterite opened this issue Jul 9, 2024 · 0 comments
Closed

LSP: support rename/find-all-references for struct members #5459

asterite opened this issue Jul 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@asterite
Copy link
Collaborator

asterite commented Jul 9, 2024

Problem

Right now there's no way to find all references to a struct member, or to rename it.

Happy Case

Ideally go to definition, find all references and rename work as expected for struct members.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

Yes

Support Needs

No response

@asterite asterite added the enhancement New feature or request label Jul 9, 2024
@asterite asterite self-assigned this Jul 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2024
# Description

## Problem

Resolves #5459

## Summary


https://github.com/noir-lang/noir/assets/209371/0ddff997-f511-4eb6-8801-eba0741b1efd

## Additional Context

None.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant