Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extra arguments on attribute functions #5473

Closed
Tracked by #4594
jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5494
Closed
Tracked by #4594

Allow extra arguments on attribute functions #5473

jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5494
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2024 •
edited
Loading

Problem

Calling an attribute via

#[attribute]
fn foo(...){}

comptime fn attribute(f: FunctionDefinition) {...}

Currently does not allow additional arguments besides f to be passed.

Happy Case

We should allow additional arguments which are Quoted by default (a bit awkward but gives some surface-level familiarity with rust and some flexibility in interpreting these values).

These arguments should all be placed after the FunctionDefiniton / StructDefinition argument.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the enhancement New feature or request label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2024
@jfecher jfecher mentioned this issue Jul 10, 2024
Closed
@jfecher jfecher changed the title Allow extra arguments on annotation functions Allow extra arguments on attribute functions Jul 11, 2024
@jfecher jfecher mentioned this issue Jul 11, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
@jfecher
feat: Allow arguments to attribute functions (#5494)
a33cafc 
# Description

## Problem\*

Resolves #5473
Resolves #5476

## Summary\*

Allows arguments to attribute functions.
- These arguments are all quoted by default. This is to replicate
something like Rust's `#[derive(Foo, Bar)]` where `Foo` and `Bar` are
meant to be traits rather than values in scope.
- Varargs is also possible if the attribute accepts a slice of Quoted
values rather than individual Quoted arguments.

## Additional Context

## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow arguments to attribute functions noir-lang/noir
1 participant
@jfecher