LSP completion incorrectly suggests private functions inside modules #5808
Assignees
Labels
bug
Something isn't working
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 23, 2024
# Description ## Problem Resolves #5808 ## Summary Reuses the same logic done when resolving a `use` or `Path` in the compiler. ## Additional Context It's debatable whether this functionality is desired, because sometimes you add a function, want to use it and autocompletion doesn't suggest it, and it takes a while for you to realize that you forgot to add `pub`. However, a lot of the suggested functions come from the std or external crates, and it doesn't make sense to reveal these private functions. This is also how Rust Analyzer works too. ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
When triggering autocompleting while completing a path, for example
foo::bar::..., LSP will suggest private (or pub(crate)) functions that aren't visible from the current module.Note that when auto-import is triggered this is not an issue, as that code already handles visibility.
Expected Behavior
Private functions are not suggested.
Bug
Private functions are incorrectly suggested.
To Reproduce
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
None
Blocker Context
No response
Nargo Version
No response
NoirJS Version
No response
Proving Backend Tooling & Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: