Comptime assertion failures should show the full backtrace #5828
Assignees
Labels
enhancement
New feature or request
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 28, 2024
# Description ## Problem Part of #5668 ## Summary Also allows `quote { ... }.as_expr()` to work with statements and L-values. Then adds an example that injects a `_context: Context` parameter to functions annotated with `#[aztec]`, and to calls inside those functions (any call for now). Also adds an incomplete `Expr::map` to help doing this. Oh, and allows unquoting `Value::Expr`, which wasn't possible before. ## Additional Context A lot is remaining, but I thought this was a good cutting point. Next I might work on #5828 because debugging comptime code without it is tricky. I didn't add docs for `Expr::map` yet as it's still not fully functional. I'll add them once it works for in all cases. ## Documentation Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [x] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 29, 2024
# Description ## Problem Resolves #5828 ## Summary `CustomDiagnostic` didn't have a `call_stack` property because so far this wasn't needed. I only added it for `FailingConstraint`, which is, _I think_, the only case where a backtrace might be needed. In all other cases (for example "wrong number of arguments" it might be clear why it's failing without needing a backtrace). Here's an example output: ``` error: Assertion failed ┌─ std/option.nr:33:16 │ 33 │ assert(self._is_some); │ ------------- │ ┌─ src/main.nr:8:9 │ 8 │ foo(); │ ----- │ ┌─ src/other.nr:2:5 │ 2 │ bar(); │ ----- · 7 │ let _ = expr.as_integer().unwrap(); │ -------------------------- │ Aborting due to 1 previous error ``` ## Additional Context None. ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Problem
When an assertion fails during comptime code evaluation, the error only shows the line that failed the assertion. That sometimes makes it impossible to understand the real cause of the assertion failure. In particular,
Option::unwrapalways fails the same way:Happy Case
The full trace is shown.
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
None
Blocker Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response
The text was updated successfully, but these errors were encountered: