Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injecting structs and impls in comptime #5913

Closed
Thunkar opened this issue Sep 4, 2024 · 0 comments · Fixed by #5927
Closed

Allow injecting structs and impls in comptime #5913

Thunkar opened this issue Sep 4, 2024 · 0 comments · Fixed by #5927
Labels
enhancement New feature or request

Comments

@Thunkar
Copy link
Contributor

Thunkar commented Sep 4, 2024

Problem

It's not possible to inject structs or impls in Quoted code returned by annotations. It's explicitly disallowed and the compiler returns: Unsupported statement type to unquote

Happy Case

Something like this should be possible:

#[generate_interface]
fn my_fn() {}


comptime fn generate_interface(f: FunctionDefinition) {
  quote {
    struct MyFnInterface {}
    
    impl MyFnInterface {
     fn properties () {...}
   }
  }
}

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Blocker

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@Thunkar Thunkar added the enhancement New feature or request label Sep 4, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 4, 2024
…5927)

# Description

## Problem\*

Resolves #5913

## Summary\*

Allows inserting new structs and impls into the program from comptime
attributes.

## Additional Context

Inserting new structs wasn't allowed originally since functions wouldn't
be able to refer to them in their signature. This use case isn't needed
for aztec currently so I'm adding this feature now and we can look into
expanding it later. See #5926

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant