Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed Assert error message in comptime can display call stack out of order #6065

Closed
jfecher opened this issue Sep 17, 2024 · 0 comments · Fixed by #6066
Closed

Failed Assert error message in comptime can display call stack out of order #6065

jfecher opened this issue Sep 17, 2024 · 0 comments · Fixed by #6066
Assignees
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Sep 17, 2024

Aim

Writing code with a failing assert at comptime, several functions deep.

Expected Behavior

The resulting error message should show the call stack in order.

Note that in the following example, or_else should not assert(self._is_some);:

error: Assertion failed
    ┌─ std/option.nr:33:16
    │
 33 │         assert(self._is_some);
    │                -------------
    │
    ┌─ std/meta/expr.nr:235:22
    │    
235 │             let result = result.or_else(|| modify_block(self, f));
    │                          ----------------------------------------
    ·    
244 │             let result = result.or_else(|| modify_let(self, f));
    │                          --------------------------------------
    ·    
340 │   ╭     expr.as_block().map(
341 │   │         |exprs: [Expr]| {
342 │   │         let exprs = modify_expressions(exprs, f);
    │   │                     ----------------------------
343 │   │         new_block(exprs)
344 │   │     }
345 │   │     )
    │   ╰─────'
    ·   │
449 │ ╭       expr.as_let().map(
450 │ │           |expr: (Expr, Option<UnresolvedType>, Expr)| {
451 │ │           let (pattern, typ, expr) = expr;
452 │ │           let pattern = pattern.modify(f);
453 │ │           let expr = expr.modify(f);
454 │ │           new_let(pattern, typ, expr)
    │ │           ---------------------------
455 │ │       }
456 │ │       )
    │ ╰───────'
    · │  
540 │         exprs.map(|expr: Expr| expr.modify(f))
    │         --------------------------------------
    ·    
650 │             quote { let $pattern = $expr; }.as_expr().unwrap()
    │             --------------------------------------------------
    │    
    ┌─ src/main.nr:15:3
    │
 15 │ #[inject_context]
    │   --------------
    ·
 38 │     let body = f.body().modify(|expr| mapping_function(expr, f));
    │                -------------------------------------------------
    │

Bug

The call stack is instead grouped by the file and shown by the line order in the file rather than the call order.

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the bug Something isn't working label Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 17, 2024
@jfecher jfecher self-assigned this Sep 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 17, 2024
# Description

## Problem\*

Resolves #6065

## Summary\*

Ensures the stack trace used in assertion failure messages at comptime
have the correct ordering. The old scheme was grouping together each
location by file and ordering by line number so I changed it to just
show filenames like we do in SSA when there's a failing assert.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant