Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods on primitive integers get mixed #6106

Closed
asterite opened this issue Sep 19, 2024 · 1 comment · Fixed by #6112
Closed

Methods on primitive integers get mixed #6106

asterite opened this issue Sep 19, 2024 · 1 comment · Fixed by #6112
Assignees
Labels
bug Something isn't working

Comments

@asterite
Copy link
Collaborator

asterite commented Sep 19, 2024

Aim

The following code:

trait Read {
    fn read(data: [Field; 1]) -> Self;
}

impl Read for Field {
    fn read(data: [Field; 1]) -> Self {
        data[0]
    }
}

impl Read for u32 {
    fn read(data: [Field; 1]) -> Self {
        data[0] as u32
    }
}

fn main() {
    let data = [1];
    let _: u32 = u32::read(data);
}

doesn't compile because the compiler thinks u32::read returns a Field.

Expected Behavior

The above code compiles without error.

Bug

The code above errors. I think it's because we store all integer-and-field methods in a single bucket (not sure!)

To Reproduce

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Nargo Version

No response

NoirJS Version

No response

Proving Backend Tooling & Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@asterite asterite added the bug Something isn't working label Sep 19, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 19, 2024
@jfecher
Copy link
Contributor

jfecher commented Sep 19, 2024

doesn't compile because the compiler thinks u32::read returns a Field.

This is because of TypeMethodKey in the node interner. All integer types share the same method key with fields so that we can still call methods on polymorphic integer literals. So it is probably selecting Field::read instead. If you reorder the impls it'll probably change as well.

@asterite asterite self-assigned this Sep 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
# Description

## Problem

Resolves #6106

## Summary

## Additional Context

Let me know if this isn't the correct way to solve this.

## Documentation

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants