Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DefinitionKind::GenericType to DefinitionKind::NumericGeneric #6181

Closed
michaeljklein opened this issue Sep 30, 2024 · 0 comments · Fixed by #6182
Closed

Rename DefinitionKind::GenericType to DefinitionKind::NumericGeneric #6181

michaeljklein opened this issue Sep 30, 2024 · 0 comments · Fixed by #6182
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

Problem

It seems like we should rename [DefinitionKind::GenericType] to DefinitionKind::NumericGeneric as it's not really a type and they're just carrying the value of the numeric generic.
#6094 (comment)

Happy Case

The enum variant is renamed

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

None

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@michaeljklein michaeljklein added the enhancement New feature or request label Sep 30, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 30, 2024
This was referenced Sep 30, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@michaeljklein
chore: rename DefinitionKind::GenericType (#6182)
79f8954 
# Description

## Problem\*

Resolves #6181

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Noir
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename DefinitionKind::GenericType noir-lang/noir
1 participant
@michaeljklein